projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
ce0e7ae
)
can: hi311x: do not report txerr and rxerr during bus-off
author
Vincent Mailhol
<mailhol.vincent@wanadoo.fr>
Tue, 19 Jul 2022 14:35:43 +0000
(23:35 +0900)
committer
Marc Kleine-Budde
<mkl@pengutronix.de>
Wed, 20 Jul 2022 07:26:49 +0000
(09:26 +0200)
During bus off, the error count is greater than 255 and can not fit in
a u8.
Fixes: 57e83fb9b746 ("can: hi311x: Add Holt HI-311x CAN driver")
Link:
https://lore.kernel.org/all/20220719143550.3681-6-mailhol.vincent@wanadoo.fr
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/spi/hi311x.c
patch
|
blob
|
history
diff --git
a/drivers/net/can/spi/hi311x.c
b/drivers/net/can/spi/hi311x.c
index ebc4ebb44c9807b8e0d228e2978815d88a10895e..bfb7c4bb5bc324747a13a11ccafcdda6798547ad 100644
(file)
--- a/
drivers/net/can/spi/hi311x.c
+++ b/
drivers/net/can/spi/hi311x.c
@@
-667,8
+667,6
@@
static irqreturn_t hi3110_can_ist(int irq, void *dev_id)
txerr = hi3110_read(spi, HI3110_READ_TEC);
rxerr = hi3110_read(spi, HI3110_READ_REC);
- cf->data[6] = txerr;
- cf->data[7] = rxerr;
tx_state = txerr >= rxerr ? new_state : 0;
rx_state = txerr <= rxerr ? new_state : 0;
can_change_state(net, cf, tx_state, rx_state);
@@
-681,6
+679,9
@@
static irqreturn_t hi3110_can_ist(int irq, void *dev_id)
hi3110_hw_sleep(spi);
break;
}
+ } else {
+ cf->data[6] = txerr;
+ cf->data[7] = rxerr;
}
}