leds: tca6507: fix potential zero passed to ERR_PTR
authorMarek Behún <kabel@kernel.org>
Sat, 26 Sep 2020 19:43:02 +0000 (21:43 +0200)
committerPavel Machek <pavel@ucw.cz>
Wed, 30 Sep 2020 16:53:27 +0000 (18:53 +0200)
Fix potential ERR_PTR(0).

Signed-off-by: Marek Behún <kabel@kernel.org>
Fixes: d78b10f5713d9 ("leds: tca6507: use fwnode API instead of OF")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/leds-tca6507.c

index 4b10ef9ae22129d09300ae1cbf0cdae394749bf9..d589c89930fdb1ba486b30db9fa9ad35f3d5c8db 100644 (file)
@@ -727,7 +727,7 @@ tca6507_led_dt_init(struct i2c_client *client)
                ret = fwnode_property_read_u32(child, "reg", &reg);
                if (ret || reg >= NUM_LEDS) {
                        fwnode_handle_put(child);
-                       return ERR_PTR(ret);
+                       return ERR_PTR(ret ? : -EINVAL);
                }
 
                tca_leds[reg] = led;