drm/amdgpu: Remove a redundant sanity check
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 20 Aug 2023 09:51:14 +0000 (11:51 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 30 Aug 2023 19:26:38 +0000 (15:26 -0400)
The case where 'num_entries' is too big, is already handled by
struct_size(), because kvmalloc() would fail.

It will return -ENOMEM instead of -EINVAL, but it is only related to a
unlikely to happen sanity check.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c

index 571fed04eb7a12854706a2e95314b59dcdd499e8..c8f59a044286d992098d4583fb645192523b289f 100644 (file)
@@ -78,10 +78,6 @@ int amdgpu_bo_list_create(struct amdgpu_device *adev, struct drm_file *filp,
        unsigned i;
        int r;
 
-       if (num_entries > (SIZE_MAX - sizeof(struct amdgpu_bo_list))
-                               / sizeof(struct amdgpu_bo_list_entry))
-               return -EINVAL;
-
        list = kvmalloc(struct_size(list, entries, num_entries), GFP_KERNEL);
        if (!list)
                return -ENOMEM;