i2c: smbus: Use device_*() functions instead of of_*()
authorAkhil R <akhilrajeev@nvidia.com>
Fri, 28 Jan 2022 11:44:27 +0000 (17:14 +0530)
committerWolfram Sang <wsa@kernel.org>
Fri, 28 Jan 2022 20:56:34 +0000 (21:56 +0100)
Change of_*() functions to device_*() for firmware agnostic usage.
This allows to have the smbus_alert interrupt without any changes
in the controller drivers using the ACPI table.

Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/i2c-core-base.c
drivers/i2c/i2c-core-smbus.c
drivers/i2c/i2c-smbus.c
include/linux/i2c-smbus.h

index 2c59dd748a49feab9f4fea5cd24811e1ed73a4f0..32a45260c1f3c54bec15a2c2e6bb6140baf1f2b4 100644 (file)
@@ -1479,7 +1479,7 @@ static int i2c_register_adapter(struct i2c_adapter *adap)
                goto out_list;
        }
 
-       res = of_i2c_setup_smbus_alert(adap);
+       res = i2c_setup_smbus_alert(adap);
        if (res)
                goto out_reg;
 
index e5b2d1465e7ed7ac6ad562998eee5ab49958245a..304c2c8fee68ef17ea2ad185791ef782d2ba9988 100644 (file)
@@ -14,6 +14,7 @@
 #include <linux/err.h>
 #include <linux/i2c.h>
 #include <linux/i2c-smbus.h>
+#include <linux/property.h>
 #include <linux/slab.h>
 
 #include "i2c-core.h"
@@ -701,13 +702,13 @@ struct i2c_client *i2c_new_smbus_alert_device(struct i2c_adapter *adapter,
 }
 EXPORT_SYMBOL_GPL(i2c_new_smbus_alert_device);
 
-#if IS_ENABLED(CONFIG_I2C_SMBUS) && IS_ENABLED(CONFIG_OF)
-int of_i2c_setup_smbus_alert(struct i2c_adapter *adapter)
+#if IS_ENABLED(CONFIG_I2C_SMBUS)
+int i2c_setup_smbus_alert(struct i2c_adapter *adapter)
 {
        int irq;
 
-       irq = of_property_match_string(adapter->dev.of_node, "interrupt-names",
-                                      "smbus_alert");
+       irq = device_property_match_string(adapter->dev.parent, "interrupt-names",
+                                          "smbus_alert");
        if (irq == -EINVAL || irq == -ENODATA)
                return 0;
        else if (irq < 0)
@@ -715,5 +716,5 @@ int of_i2c_setup_smbus_alert(struct i2c_adapter *adapter)
 
        return PTR_ERR_OR_ZERO(i2c_new_smbus_alert_device(adapter, NULL));
 }
-EXPORT_SYMBOL_GPL(of_i2c_setup_smbus_alert);
+EXPORT_SYMBOL_GPL(i2c_setup_smbus_alert);
 #endif
index d3d06e3b4f3b317d014b8e7f2a077a508168b52c..775332945ad04522ddd482e3b032641e10eaffbe 100644 (file)
@@ -13,7 +13,7 @@
 #include <linux/interrupt.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/of_irq.h>
+#include <linux/property.h>
 #include <linux/slab.h>
 #include <linux/workqueue.h>
 
@@ -128,7 +128,8 @@ static int smbalert_probe(struct i2c_client *ara,
        if (setup) {
                irq = setup->irq;
        } else {
-               irq = of_irq_get_byname(adapter->dev.of_node, "smbus_alert");
+               irq = fwnode_irq_get_byname(dev_fwnode(adapter->dev.parent),
+                                           "smbus_alert");
                if (irq <= 0)
                        return irq;
        }
index 1ef421818d3a8fcc6e5b78458a0c464505b4129c..95cf902e0bdae37e0dc229aa8a4bbffa96ee4bb8 100644 (file)
@@ -30,10 +30,10 @@ struct i2c_client *i2c_new_smbus_alert_device(struct i2c_adapter *adapter,
                                              struct i2c_smbus_alert_setup *setup);
 int i2c_handle_smbus_alert(struct i2c_client *ara);
 
-#if IS_ENABLED(CONFIG_I2C_SMBUS) && IS_ENABLED(CONFIG_OF)
-int of_i2c_setup_smbus_alert(struct i2c_adapter *adap);
+#if IS_ENABLED(CONFIG_I2C_SMBUS)
+int i2c_setup_smbus_alert(struct i2c_adapter *adap);
 #else
-static inline int of_i2c_setup_smbus_alert(struct i2c_adapter *adap)
+static inline int i2c_setup_smbus_alert(struct i2c_adapter *adap)
 {
        return 0;
 }