ravb: Correct buffer size to map for R-Car Rx
authorNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Fri, 8 Mar 2024 22:42:37 +0000 (23:42 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 11 Mar 2024 22:16:57 +0000 (15:16 -0700)
When creating a helper to allocate and align an skb one location where
the skb data size was updated was missed. This can lead to a warning
being printed when the memory is being unmapped as it now always unmap
the maximum frame size, instead of the size after it have been
aligned.

This was correctly done for RZ/G2L but missed for R-Car.

Fixes: cfbad64706c1 ("ravb: Create helper to allocate skb and align it")
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20240308224237.496924-1-niklas.soderlund+renesas@ragnatech.se
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/renesas/ravb_main.c

index fa48ff4aba2d44bcac95451161e7a10e3dc7a4a7..d1be030c88483ae217a84d9047d883dbf6cfad54 100644 (file)
@@ -979,7 +979,7 @@ static bool ravb_rx_rcar(struct net_device *ndev, int *quota, int q)
                        if (!skb)
                                break;  /* Better luck next round. */
                        dma_addr = dma_map_single(ndev->dev.parent, skb->data,
-                                                 le16_to_cpu(desc->ds_cc),
+                                                 priv->info->rx_max_frame_size,
                                                  DMA_FROM_DEVICE);
                        skb_checksum_none_assert(skb);
                        /* We just set the data size to 0 for a failed mapping