leds: el15203000: Annotate struct el15203000 with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 15 Sep 2023 20:09:56 +0000 (13:09 -0700)
committerLee Jones <lee@kernel.org>
Wed, 1 Nov 2023 11:28:28 +0000 (11:28 +0000)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct el15203000.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230915200955.never.871-kees@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-el15203000.c

index 7e7b617bcd56e4812c16bbe9f97af2e820253d16..d40194a3029f570f4f6122c5500f36a9384f1179 100644 (file)
@@ -80,7 +80,7 @@ struct el15203000 {
        struct spi_device       *spi;
        unsigned long           delay;
        size_t                  count;
-       struct el15203000_led   leds[];
+       struct el15203000_led   leds[] __counted_by(count);
 };
 
 #define to_el15203000_led(d)   container_of(d, struct el15203000_led, ldev)