dmaengine: axi-dmac: Small code cleanup
authorPaul Cercueil <paul@crapouillou.net>
Fri, 15 Dec 2023 13:13:09 +0000 (14:13 +0100)
committerVinod Koul <vkoul@kernel.org>
Thu, 21 Dec 2023 16:09:56 +0000 (21:39 +0530)
Use a for() loop instead of a while() loop in axi_dmac_fill_linear_sg().
This makes the code leaner and cleaner overall, and does not introduce
any functional change.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Link: https://lore.kernel.org/r/20231215131313.23840-2-paul@crapouillou.net
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dma-axi-dmac.c

index 2457a420c13d72cde2509f6a446269b166b06cdc..760940b21eabf39ad565eda96fad086eae00ca0b 100644 (file)
@@ -508,16 +508,13 @@ static struct axi_dmac_sg *axi_dmac_fill_linear_sg(struct axi_dmac_chan *chan,
        segment_size = ((segment_size - 1) | chan->length_align_mask) + 1;
 
        for (i = 0; i < num_periods; i++) {
-               len = period_len;
-
-               while (len > segment_size) {
+               for (len = period_len; len > segment_size; sg++) {
                        if (direction == DMA_DEV_TO_MEM)
                                sg->dest_addr = addr;
                        else
                                sg->src_addr = addr;
                        sg->x_len = segment_size;
                        sg->y_len = 1;
-                       sg++;
                        addr += segment_size;
                        len -= segment_size;
                }