projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6779886
)
ASoC: fsl_xcvr: check return value after calling platform_get_resource_byname()
author
Yang Yingliang
<yangyingliang@huawei.com>
Tue, 15 Jun 2021 01:39:22 +0000
(09:39 +0800)
committer
Mark Brown
<broonie@kernel.org>
Mon, 21 Jun 2021 12:03:18 +0000
(13:03 +0100)
It will cause null-ptr-deref if platform_get_resource_byname() returns NULL,
we need check the return value.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link:
https://lore.kernel.org/r/20210615013922.784296-10-yangyingliang@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/fsl_xcvr.c
patch
|
blob
|
history
diff --git
a/sound/soc/fsl/fsl_xcvr.c
b/sound/soc/fsl/fsl_xcvr.c
index df7c189d97ddd673f7894ee82e7655c8a6041078..1330e190e1ffdb0666cfaa9f09636d8d69db17f9 100644
(file)
--- a/
sound/soc/fsl/fsl_xcvr.c
+++ b/
sound/soc/fsl/fsl_xcvr.c
@@
-1202,6
+1202,10
@@
static int fsl_xcvr_probe(struct platform_device *pdev)
rx_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rxfifo");
tx_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "txfifo");
+ if (!rx_res || !tx_res) {
+ dev_err(dev, "could not find rxfifo or txfifo resource\n");
+ return -EINVAL;
+ }
xcvr->dma_prms_rx.chan_name = "rx";
xcvr->dma_prms_tx.chan_name = "tx";
xcvr->dma_prms_rx.addr = rx_res->start;