migration: dump str in migrate_set_state trace
authorPeter Xu <peterx@redhat.com>
Wed, 30 Aug 2017 08:32:01 +0000 (16:32 +0800)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Wed, 6 Sep 2017 15:36:38 +0000 (16:36 +0100)
Strings are more readable for debugging.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <1504081950-2528-5-git-send-email-peterx@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
  Fixed up merge with 977c73

migration/migration.c
migration/trace-events

index 9838ccc885d333f8a3f59480a48e1ed08e23f722..959e8ec88eae2d281253589438ad395ae20a4a9c 100644 (file)
@@ -913,8 +913,9 @@ void qmp_migrate_start_postcopy(Error **errp)
 
 void migrate_set_state(int *state, int old_state, int new_state)
 {
+    assert(new_state < MIGRATION_STATUS__MAX);
     if (atomic_cmpxchg(state, old_state, new_state) == old_state) {
-        trace_migrate_set_state(new_state);
+        trace_migrate_set_state(MigrationStatus_str(new_state));
         migrate_generate_event(new_state);
     }
 }
index 7a3b5144ff4770bc2059b50316f01eb680a144de..d2910a6e7b83dca2a48909b1faceadf28eeb514e 100644 (file)
@@ -80,7 +80,7 @@ ram_save_queue_pages(const char *rbname, size_t start, size_t len) "%s: start: 0
 # migration/migration.c
 await_return_path_close_on_source_close(void) ""
 await_return_path_close_on_source_joining(void) ""
-migrate_set_state(int new_state) "new state %d"
+migrate_set_state(const char *new_state) "new state %s"
 migrate_fd_cleanup(void) ""
 migrate_fd_error(const char *error_desc) "error=%s"
 migrate_fd_cancel(void) ""