usb: Use of_property_present() for testing DT property presence
authorRob Herring <robh@kernel.org>
Fri, 10 Mar 2023 14:47:27 +0000 (08:47 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 Mar 2023 11:14:50 +0000 (12:14 +0100)
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230310144728.1545786-1-robh@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/snps_udc_plat.c
drivers/usb/host/fsl-mph-dr-of.c
drivers/usb/musb/omap2430.c
drivers/usb/phy/phy-mxs-usb.c
drivers/usb/phy/phy-tegra-usb.c

index 8bbb89c8034876c98a09b6b35c299c7b07f0dbd3..0d3e705655b978983c44431ae047b50f9ca47ade 100644 (file)
@@ -158,7 +158,7 @@ static int udc_plat_probe(struct platform_device *pdev)
        }
 
        /* Register for extcon if supported */
-       if (of_get_property(dev->of_node, "extcon", NULL)) {
+       if (of_property_present(dev->of_node, "extcon")) {
                udc->edev = extcon_get_edev_by_phandle(dev, 0);
                if (IS_ERR(udc->edev)) {
                        if (PTR_ERR(udc->edev) == -EPROBE_DEFER)
index 46c6a152b86554161886c0130dab12f7749a1406..cdf71b716c2b1d7efef51cb0d89aedaf4c7f2c3b 100644 (file)
@@ -200,10 +200,10 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_device *ofdev)
        dev_data = get_dr_mode_data(np);
 
        if (of_device_is_compatible(np, "fsl-usb2-mph")) {
-               if (of_get_property(np, "port0", NULL))
+               if (of_property_present(np, "port0"))
                        pdata->port_enables |= FSL_USB2_PORT0_ENABLED;
 
-               if (of_get_property(np, "port1", NULL))
+               if (of_property_present(np, "port1"))
                        pdata->port_enables |= FSL_USB2_PORT1_ENABLED;
 
                pdata->operating_mode = FSL_USB2_MPH_HOST;
index 44a21ec865fb219ec80eb34e66c46bc1ee7c6265..7f305b352591c43e57f3edf5182bec9a2cc9e755 100644 (file)
@@ -334,7 +334,7 @@ static int omap2430_probe(struct platform_device *pdev)
         * Legacy SoCs using omap_device get confused if node is moved
         * because of interconnect properties mixed into the node.
         */
-       if (of_get_property(np, "ti,hwmods", NULL)) {
+       if (of_property_present(np, "ti,hwmods")) {
                dev_warn(&pdev->dev, "please update to probe with ti-sysc\n");
                populate_irqs = true;
        } else {
index d2836ef5d15c7609277f18ceaab5e1f91f148f8a..0a8e3fd699ca334cd84b0e179b5e076edc11164e 100644 (file)
@@ -733,7 +733,7 @@ static int mxs_phy_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        /* Some SoCs don't have anatop registers */
-       if (of_get_property(np, "fsl,anatop", NULL)) {
+       if (of_property_present(np, "fsl,anatop")) {
                mxs_phy->regmap_anatop = syscon_regmap_lookup_by_phandle
                        (np, "fsl,anatop");
                if (IS_ERR(mxs_phy->regmap_anatop)) {
index f0240107edb15270d32ec67e19fe5dc200838665..4d207ce3ddf203f4a8f607aa51828b5dbb608c79 100644 (file)
@@ -1375,7 +1375,7 @@ static int tegra_usb_phy_probe(struct platform_device *pdev)
        tegra_phy->is_legacy_phy =
                of_property_read_bool(np, "nvidia,has-legacy-mode");
 
-       if (of_find_property(np, "dr_mode", NULL))
+       if (of_property_present(np, "dr_mode"))
                tegra_phy->mode = usb_get_dr_mode(&pdev->dev);
        else
                tegra_phy->mode = USB_DR_MODE_HOST;