media: amphion: return error if format is unsupported by vpu

return error if format is unsupported by vpu,
otherwise the vpu will be stalled at decoding

Fixes: 3cd084519c6f9 ("media: amphion: add vpu v4l2 m2m support")
Signed-off-by: Ming Qian <ming.qian@nxp.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/platform/amphion/vpu_malone.c b/drivers/media/platform/amphion/vpu_malone.c
index 7a06011a217adcc6e786cc631ebba163195482ee..c62b49e850604c7dff6cbedcc7ce9521157582a2 100644 (file)
--- a/drivers/media/platform/amphion/vpu_malone.c
+++ b/drivers/media/platform/amphion/vpu_malone.c
@@ -626,6 +626,8 @@ static int vpu_malone_set_params(struct vpu_shared_addr *shared,
        enum vpu_malone_format malone_format;
 
        malone_format = vpu_malone_format_remap(params->codec_format);
+       if (WARN_ON(malone_format == MALONE_FMT_NULL))
+               return -EINVAL;
        iface->udata_buffer[instance].base = params->udata.base;
        iface->udata_buffer[instance].slot_size = params->udata.size;
 

diff --git a/drivers/media/platform/amphion/vpu_v4l2.c b/drivers/media/platform/amphion/vpu_v4l2.c
index 446f07d09d0bb08f5e21eaef7649767db83131bb..da455e5ab33769abad7b132a9bd6d183d22a1f58 100644 (file)
--- a/drivers/media/platform/amphion/vpu_v4l2.c
+++ b/drivers/media/platform/amphion/vpu_v4l2.c
@@ -500,10 +500,12 @@ static int vpu_vb2_start_streaming(struct vb2_queue *q, unsigned int count)
                  fmt->sizeimage[1], fmt->bytesperline[1],
                  fmt->sizeimage[2], fmt->bytesperline[2],
                  q->num_buffers);
-       call_void_vop(inst, start, q->type);
+       ret = call_vop(inst, start, q->type);
        vb2_clear_last_buffer_dequeued(q);
+       if (ret)
+               vpu_vb2_buffers_return(inst, q->type, VB2_BUF_STATE_QUEUED);
 
-       return 0;
+       return ret;
 }
 
 static void vpu_vb2_stop_streaming(struct vb2_queue *q)