btrfs: relocation: use more natural types for tree_block bitfields
authorDavid Sterba <dsterba@suse.com>
Fri, 22 Sep 2023 11:07:14 +0000 (13:07 +0200)
committerDavid Sterba <dsterba@suse.com>
Thu, 12 Oct 2023 14:44:13 +0000 (16:44 +0200)
We don't need to use bitfields for tree_block::level and
tree_block::key_ready, there's enough padding in the structure for
proper types.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/relocation.c

index 6e8e14d1aeaa4db94c67e87d5bb0f5854001b213..9ff3572a845113dc8d2a11edab31b8d9dc796d4d 100644 (file)
@@ -111,8 +111,8 @@ struct tree_block {
        }; /* Use rb_simple_node for search/insert */
        u64 owner;
        struct btrfs_key key;
-       unsigned int level:8;
-       unsigned int key_ready:1;
+       u8 level;
+       bool key_ready;
 };
 
 #define MAX_EXTENTS 128
@@ -2664,7 +2664,7 @@ static int get_tree_block_key(struct btrfs_fs_info *fs_info,
        else
                btrfs_node_key_to_cpu(eb, &block->key, 0);
        free_extent_buffer(eb);
-       block->key_ready = 1;
+       block->key_ready = true;
        return 0;
 }
 
@@ -3313,7 +3313,7 @@ static int add_tree_block(struct reloc_control *rc,
        block->key.objectid = rc->extent_root->fs_info->nodesize;
        block->key.offset = generation;
        block->level = level;
-       block->key_ready = 0;
+       block->key_ready = false;
        block->owner = owner;
 
        rb_node = rb_simple_insert(blocks, block->bytenr, &block->rb_node);