dmaengine: idxd: fix resource leak on dmaengine driver disable

The wq resources needs to be released before the kernel type is reset by
__drv_disable_wq(). With dma channels unregistered and wq quiesced, all the
wq resources for dmaengine can be freed. There is no need to wait until wq
is disabled. With the wq->type being reset to "unknown", the driver is
skipping the freeing of the resources.

Fixes: 0cda4f6986a3 ("dmaengine: idxd: create dmaengine driver for wq 'device'")
Reported-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Tested-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/163517405099.3484556.12521975053711345244.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/dma/idxd/dma.c b/drivers/dma/idxd/dma.c
index b90b085d18cffe38e1df61069bebe33e2fa2570b..c39e9483206adec9b7917dbf192f3989ddcf1567 100644 (file)
--- a/drivers/dma/idxd/dma.c
+++ b/drivers/dma/idxd/dma.c
@@ -329,10 +329,9 @@ static void idxd_dmaengine_drv_remove(struct idxd_dev *idxd_dev)
        mutex_lock(&wq->wq_lock);
        idxd_wq_quiesce(wq);
        idxd_unregister_dma_channel(wq);
+       idxd_wq_free_resources(wq);
        __drv_disable_wq(wq);
        percpu_ref_exit(&wq->wq_active);
-       idxd_wq_free_resources(wq);
-       wq->type = IDXD_WQT_NONE;
        mutex_unlock(&wq->wq_lock);
 }