ASoC: rt1016: clarify expression
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 2 Mar 2021 21:25:08 +0000 (15:25 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 13:09:57 +0000 (13:09 +0000)
cppcheck warning:

sound/soc/codecs/rt1016.c:503:61: style: Boolean result is used in
bitwise operation. Clarify expression with
parentheses. [clarifyCondition]
  (pll_code.m_bp ? 0 : pll_code.m_code) << RT1016_PLL_M_SFT |
                                                            ^
sound/soc/codecs/rt1016.c:506:40: style: Boolean result is used in
bitwise operation. Clarify expression with
parentheses. [clarifyCondition]
  pll_code.k_bp << RT1016_PLL_K_BP_SFT |
                                       ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210302212527.55158-6-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt1016.c

index c14a809da52bba4023e2c8a03d952ec990b24374..7561d202274cf939a2e16bf322986b06c60b4845 100644 (file)
@@ -500,10 +500,11 @@ static int rt1016_set_component_pll(struct snd_soc_component *component,
                (pll_code.k_bp ? 0 : pll_code.k_code));
 
        snd_soc_component_write(component, RT1016_PLL1,
-               (pll_code.m_bp ? 0 : pll_code.m_code) << RT1016_PLL_M_SFT |
-               pll_code.m_bp << RT1016_PLL_M_BP_SFT | pll_code.n_code);
+               ((pll_code.m_bp ? 0 : pll_code.m_code) << RT1016_PLL_M_SFT) |
+               (pll_code.m_bp << RT1016_PLL_M_BP_SFT) |
+               pll_code.n_code);
        snd_soc_component_write(component, RT1016_PLL2,
-               pll_code.k_bp << RT1016_PLL_K_BP_SFT |
+               (pll_code.k_bp << RT1016_PLL_K_BP_SFT) |
                (pll_code.k_bp ? 0 : pll_code.k_code));
 
        rt1016->pll_in = freq_in;