dmaengine: at_xdmac: Drop always true check
authorTudor Ambarus <tudor.ambarus@microchip.com>
Thu, 23 Jan 2020 14:03:12 +0000 (14:03 +0000)
committerVinod Koul <vkoul@kernel.org>
Tue, 25 Feb 2020 05:57:27 +0000 (11:27 +0530)
The code in cause is already in the else case of
'if (at_xdmac_chan_is_cyclic(atchan))', drop the redundant check.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Link: https://lore.kernel.org/r/20200123140237.125799-7-tudor.ambarus@microchip.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/at_xdmac.c

index f71c9f77d40594e08f02642d73038ec1eadf4216..3d6e84def7a6858318deecad4c2c33adb7629b84 100644 (file)
@@ -1656,11 +1656,9 @@ static void at_xdmac_tasklet(unsigned long data)
                at_xdmac_remove_xfer(atchan, desc);
                spin_unlock(&atchan->lock);
 
-               if (!at_xdmac_chan_is_cyclic(atchan)) {
-                       dma_cookie_complete(txd);
-                       if (txd->flags & DMA_PREP_INTERRUPT)
-                               dmaengine_desc_get_callback_invoke(txd, NULL);
-               }
+               dma_cookie_complete(txd);
+               if (txd->flags & DMA_PREP_INTERRUPT)
+                       dmaengine_desc_get_callback_invoke(txd, NULL);
 
                dma_run_dependencies(txd);