projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f2eb43f
)
drm/i915/dpll: drop a useless I915_STATE_WARN_ON()
author
Jani Nikula
<jani.nikula@intel.com>
Fri, 12 May 2023 11:04:41 +0000
(14:04 +0300)
committer
Jani Nikula
<jani.nikula@intel.com>
Mon, 15 May 2023 09:13:37 +0000
(12:13 +0300)
In general, we don't do assertions that a function gets called on the
right platforms, and if we did, it should not be a state warn.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link:
https://patchwork.freedesktop.org/patch/msgid/20230512110444.1448231-1-jani.nikula@intel.com
drivers/gpu/drm/i915/display/intel_dpll_mgr.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
index ed372d227aa73f6690404cf54a6bf3d346096658..936b8de9e439b6c78d0e51b89dfcad7447b442ff 100644
(file)
--- a/
drivers/gpu/drm/i915/display/intel_dpll_mgr.c
+++ b/
drivers/gpu/drm/i915/display/intel_dpll_mgr.c
@@
-464,8
+464,6
@@
static void ibx_assert_pch_refclk_enabled(struct drm_i915_private *dev_priv)
u32 val;
bool enabled;
- I915_STATE_WARN_ON(!(HAS_PCH_IBX(dev_priv) || HAS_PCH_CPT(dev_priv)));
-
val = intel_de_read(dev_priv, PCH_DREF_CONTROL);
enabled = !!(val & (DREF_SSC_SOURCE_MASK | DREF_NONSPREAD_SOURCE_MASK |
DREF_SUPERSPREAD_SOURCE_MASK));