net: marvell: prestera: fix patchwork build problems
authorVolodymyr Mytnyk <vmytnyk@marvell.com>
Thu, 4 Nov 2021 13:12:52 +0000 (15:12 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 5 Nov 2021 14:26:22 +0000 (14:26 +0000)
fix the remaining build issues reported by patchwork
in firmware v4.0 support commit which has been already
merged.

Fix patchwork issues:
 - source inline
 - checkpatch

Fixes: bb5dbf2cc64d ("net: marvell: prestera: add firmware v4.0 support")
Signed-off-by: Volodymyr Mytnyk <vmytnyk@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/prestera/prestera_ethtool.c
drivers/net/ethernet/marvell/prestera/prestera_hw.c
drivers/net/ethernet/marvell/prestera/prestera_main.c
drivers/net/ethernet/marvell/prestera/prestera_pci.c

index 6011454dba71f239e3b4b64b61a53a22a201c8d2..40d5b89573bb0bff078cc8c9ba77b6d3dca7787a 100644 (file)
@@ -499,7 +499,8 @@ static void prestera_port_mdix_get(struct ethtool_link_ksettings *ecmd,
 {
        struct prestera_port_phy_state *state = &port->state_phy;
 
-       if (prestera_hw_port_phy_mode_get(port, &state->mdix, NULL, NULL, NULL)) {
+       if (prestera_hw_port_phy_mode_get(port,
+                                         &state->mdix, NULL, NULL, NULL)) {
                netdev_warn(port->dev, "MDIX params get failed");
                state->mdix = ETH_TP_MDI_INVALID;
        }
index 4f5f52dcdd9d2814aa8ae9ea380141f77df0cfa5..bc3c9310678ae63793e97b104624fcea89d66de6 100644 (file)
@@ -1356,7 +1356,8 @@ int prestera_hw_port_speed_get(const struct prestera_port *port, u32 *speed)
 int prestera_hw_port_autoneg_restart(struct prestera_port *port)
 {
        struct prestera_msg_port_attr_req req = {
-               .attr = __cpu_to_le32(PRESTERA_CMD_PORT_ATTR_PHY_AUTONEG_RESTART),
+               .attr =
+                   __cpu_to_le32(PRESTERA_CMD_PORT_ATTR_PHY_AUTONEG_RESTART),
                .port = __cpu_to_le32(port->hw_id),
                .dev = __cpu_to_le32(port->dev_id),
        };
index 625b40149facfbb7bac9cb8892bbf7a6dc4a028e..4369a3ffad45b7c660c5a93ecb20225e5afa7f3c 100644 (file)
@@ -405,7 +405,8 @@ static int prestera_port_create(struct prestera_switch *sw, u32 id)
 
        err = prestera_port_cfg_mac_write(port, &cfg_mac);
        if (err) {
-               dev_err(prestera_dev(sw), "Failed to set port(%u) mac mode\n", id);
+               dev_err(prestera_dev(sw),
+                       "Failed to set port(%u) mac mode\n", id);
                goto err_port_init;
        }
 
@@ -418,7 +419,8 @@ static int prestera_port_create(struct prestera_switch *sw, u32 id)
                                                    false, 0, 0,
                                                    port->cfg_phy.mdix);
                if (err) {
-                       dev_err(prestera_dev(sw), "Failed to set port(%u) phy mode\n", id);
+                       dev_err(prestera_dev(sw),
+                               "Failed to set port(%u) phy mode\n", id);
                        goto err_port_init;
                }
        }
index 5d4d410b07c8cccf812fb1144cfe9bd302909c78..461259b3655ab93e63176c961f2ebd541615f48f 100644 (file)
@@ -411,7 +411,8 @@ static int prestera_fw_cmd_send(struct prestera_fw *fw, int qid,
                goto cmd_exit;
        }
 
-       memcpy_fromio(out_msg, prestera_fw_cmdq_buf(fw, qid) + in_size, ret_size);
+       memcpy_fromio(out_msg,
+                     prestera_fw_cmdq_buf(fw, qid) + in_size, ret_size);
 
 cmd_exit:
        prestera_fw_write(fw, PRESTERA_CMDQ_REQ_CTL_REG(qid),