staging: rtl8712: r8712_xmit_resource_alloc(): Change return values
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Wed, 26 Jun 2019 06:09:39 +0000 (11:39 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 1 Jul 2019 08:44:06 +0000 (10:44 +0200)
Change call site of function r8712_xmit_resource_alloc to add a check
for its return value.
Change return values of r8712_xmit_resource_alloc from
_SUCCESS/_FAIL to 0/-ENOMEM.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8712/rtl871x_xmit.c
drivers/staging/rtl8712/xmit_linux.c

index 5d63d2721eb6c6cc81834a76b61c1c827c6f079e..0a26d71e5340267686178f6aeaa224ee897a34ba 100644 (file)
@@ -133,7 +133,8 @@ sint _r8712_init_xmit_priv(struct xmit_priv *pxmitpriv,
                pxmitbuf->pbuf = pxmitbuf->pallocated_buf + XMITBUF_ALIGN_SZ -
                                 ((addr_t) (pxmitbuf->pallocated_buf) &
                                 (XMITBUF_ALIGN_SZ - 1));
-               r8712_xmit_resource_alloc(padapter, pxmitbuf);
+               if (r8712_xmit_resource_alloc(padapter, pxmitbuf))
+                       return _FAIL;
                list_add_tail(&pxmitbuf->list,
                                 &(pxmitpriv->free_xmitbuf_queue.queue));
                pxmitbuf++;
index dc03f0d0c85d7fb39460fe55104da2d8b64f64f0..01d713d027b0b695ae030d3ae3693994b6b965c1 100644 (file)
@@ -120,11 +120,11 @@ int r8712_xmit_resource_alloc(struct _adapter *padapter,
                pxmitbuf->pxmit_urb[i] = usb_alloc_urb(0, GFP_KERNEL);
                if (!pxmitbuf->pxmit_urb[i]) {
                        netdev_err(padapter->pnetdev, "pxmitbuf->pxmit_urb[i] == NULL\n");
-                       return _FAIL;
+                       return -ENOMEM;
                }
                kmemleak_not_leak(pxmitbuf->pxmit_urb[i]);
        }
-       return _SUCCESS;
+       return 0;
 }
 
 void r8712_xmit_resource_free(struct _adapter *padapter,