net: dsa: mv88e6xxx: fix mdio bus' phy_mask member
authorMarek Behún <kabel@kernel.org>
Sun, 19 Mar 2023 14:02:38 +0000 (15:02 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 21 Mar 2023 11:52:04 +0000 (12:52 +0100)
Commit 2c7e46edbd03 ("net: dsa: mv88e6xxx: mask apparently non-existing
phys during probing") added non-trivial bus->phy_mask in
mv88e6xxx_mdio_register() in order to avoid excessive mdio bus
transactions during probing.

But the mask is incorrect for switches with non-zero phy_base_addr (such
as 88E6341).

Fix this.

Fixes: 2c7e46edbd03 ("net: dsa: mv88e6xxx: mask apparently non-existing phys during probing")
Signed-off-by: Marek Behún <kabel@kernel.org>
Tested-by: Klaus Kudielka <klaus.kudielka@gmail.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20230319140238.9470-1-kabel@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/dsa/mv88e6xxx/chip.c

index 260e38c5c6e66c0534da6dd582681e83640071e2..b73d1d6747b7067d18409d5f99919e1d17bad0a1 100644 (file)
@@ -3805,7 +3805,9 @@ static int mv88e6xxx_mdio_register(struct mv88e6xxx_chip *chip,
        bus->read_c45 = mv88e6xxx_mdio_read_c45;
        bus->write_c45 = mv88e6xxx_mdio_write_c45;
        bus->parent = chip->dev;
-       bus->phy_mask = GENMASK(31, mv88e6xxx_num_ports(chip));
+       bus->phy_mask = ~GENMASK(chip->info->phy_base_addr +
+                                mv88e6xxx_num_ports(chip) - 1,
+                                chip->info->phy_base_addr);
 
        if (!external) {
                err = mv88e6xxx_g2_irq_mdio_setup(chip, bus);