staging: r8188eu: FAT_State is always FAT_NORMAL_STATE
authorMichael Straube <straube.linux@gmail.com>
Tue, 28 Dec 2021 10:11:16 +0000 (11:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Dec 2021 16:14:29 +0000 (17:14 +0100)
In this driver pDM_FatTable->FAT_State is always FAT_NORMAL_STATE.
So the check 'if (pDM_FatTable->FAT_State == FAT_TRAINING_STATE)'
is always false. Remove dead code that is executed only if that
check is true.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20211228101120.9120-7-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/odm_HWConfig.c

index 1fb2d9a16fea43537cfabe640fd6590abc410e29..9de16383cb2dfed4ade86342e4ae15ae92c6241a 100644 (file)
@@ -251,15 +251,7 @@ static void odm_Process_RSSIForDM(struct odm_dm_struct *dm_odm,
        isCCKrate = ((pPktinfo->Rate >= DESC92C_RATE1M) && (pPktinfo->Rate <= DESC92C_RATE11M)) ? true : false;
 
        /* Smart Antenna Debug Message------------------  */
-       if (dm_odm->AntDivType == CG_TRX_SMART_ANTDIV) {
-               if (pDM_FatTable->FAT_State == FAT_TRAINING_STATE) {
-                       if (pPktinfo->bPacketToSelf) {
-                               antsel_tr_mux = (pDM_FatTable->antsel_rx_keep_2 << 2) |
-                                               (pDM_FatTable->antsel_rx_keep_1 << 1) |
-                                               pDM_FatTable->antsel_rx_keep_0;
-                       }
-               }
-       } else if ((dm_odm->AntDivType == CG_TRX_HW_ANTDIV) || (dm_odm->AntDivType == CGCS_RX_HW_ANTDIV)) {
+       if ((dm_odm->AntDivType == CG_TRX_HW_ANTDIV) || (dm_odm->AntDivType == CGCS_RX_HW_ANTDIV)) {
                if (pPktinfo->bPacketToSelf || pPktinfo->bPacketBeacon) {
                        antsel_tr_mux = (pDM_FatTable->antsel_rx_keep_2 << 2) |
                                        (pDM_FatTable->antsel_rx_keep_1 << 1) | pDM_FatTable->antsel_rx_keep_0;