drm/i915: Constify remainder of the state checker
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 4 Oct 2023 15:56:04 +0000 (18:56 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 6 Oct 2023 21:12:46 +0000 (00:12 +0300)
Mark the remaining crtc states used by the state checker as const.
There is no reason to ever mutate them here.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231004155607.7719-10-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_modeset_verify.c
drivers/gpu/drm/i915/display/intel_modeset_verify.h

index 3acd7e086a3b5d2de15fd0c62175c08f617d540e..f16babc613e676fa0799d0b10472971f01715893 100644 (file)
@@ -23,8 +23,8 @@
  * Cross check the actual hw state with our own modeset state tracking (and its
  * internal consistency).
  */
-static void intel_connector_verify_state(struct intel_crtc_state *crtc_state,
-                                        struct drm_connector_state *conn_state)
+static void intel_connector_verify_state(const struct intel_crtc_state *crtc_state,
+                                        const struct drm_connector_state *conn_state)
 {
        struct intel_connector *connector = to_intel_connector(conn_state->connector);
        struct drm_i915_private *i915 = to_i915(connector->base.dev);
@@ -66,12 +66,12 @@ verify_connector_state(struct intel_atomic_state *state,
                       struct intel_crtc *crtc)
 {
        struct drm_connector *connector;
-       struct drm_connector_state *new_conn_state;
+       const struct drm_connector_state *new_conn_state;
        int i;
 
        for_each_new_connector_in_state(&state->base, connector, new_conn_state, i) {
                struct drm_encoder *encoder = connector->encoder;
-               struct intel_crtc_state *crtc_state = NULL;
+               const struct intel_crtc_state *crtc_state = NULL;
 
                if (new_conn_state->crtc != &crtc->base)
                        continue;
@@ -110,7 +110,7 @@ verify_encoder_state(struct drm_i915_private *dev_priv, struct intel_atomic_stat
 {
        struct intel_encoder *encoder;
        struct drm_connector *connector;
-       struct drm_connector_state *old_conn_state, *new_conn_state;
+       const struct drm_connector_state *old_conn_state, *new_conn_state;
        int i;
 
        for_each_intel_encoder(&dev_priv->drm, encoder) {
@@ -226,8 +226,8 @@ verify_crtc_state(struct intel_atomic_state *state,
 
 void intel_modeset_verify_crtc(struct intel_crtc *crtc,
                               struct intel_atomic_state *state,
-                              struct intel_crtc_state *old_crtc_state,
-                              struct intel_crtc_state *new_crtc_state)
+                              const struct intel_crtc_state *old_crtc_state,
+                              const struct intel_crtc_state *new_crtc_state)
 {
        if (!intel_crtc_needs_modeset(new_crtc_state) &&
            !intel_crtc_needs_fastset(new_crtc_state))
index 2d6fbe4f7846de2d0754874c7a8bce815e171ff2..77786a877f6add0421afc10721f5f7747791f79f 100644 (file)
@@ -13,8 +13,8 @@ struct intel_crtc_state;
 
 void intel_modeset_verify_crtc(struct intel_crtc *crtc,
                               struct intel_atomic_state *state,
-                              struct intel_crtc_state *old_crtc_state,
-                              struct intel_crtc_state *new_crtc_state);
+                              const struct intel_crtc_state *old_crtc_state,
+                              const struct intel_crtc_state *new_crtc_state);
 void intel_modeset_verify_disabled(struct drm_i915_private *dev_priv,
                                   struct intel_atomic_state *state);