drm/vmwgfx: Zero initialize handle in vmw_execbuf_process
authorNathan Chancellor <natechancellor@gmail.com>
Tue, 12 Mar 2019 03:24:46 +0000 (20:24 -0700)
committerDeepak Rawat <drawat@vmware.com>
Mon, 8 Apr 2019 17:29:05 +0000 (10:29 -0700)
When building with -Wsometimes-uninitialized, Clang warns:

drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3964:7: warning: variable
'handle' is used uninitialized whenever '?:' condition is false
[-Wsometimes-uninitialized]

It's not wrong; however, in practice, this is never an issue because
the value of handle isn't used when user_fence_rep is NULL because
vmw_execbuf_copy_fence_user returns immediately when that is the case.
Just zero initialize this variable so that Clang no longer warns.

Link: https://github.com/ClangBuiltLinux/linux/issues/397
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Deepak Rawat <drawat@vmware.com>
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c

index 6cc9837b10ec1aa51f759bde83420e0546b478bc..2ff7ba04d8c8120592a4509b0efeac84b300bdfa 100644 (file)
@@ -3620,7 +3620,7 @@ int vmw_execbuf_process(struct drm_file *file_priv,
        struct vmw_sw_context *sw_context = &dev_priv->ctx;
        struct vmw_fence_obj *fence = NULL;
        struct vmw_cmdbuf_header *header;
-       uint32_t handle;
+       uint32_t handle = 0;
        int ret;
        int32_t out_fence_fd = -1;
        struct sync_file *sync_file = NULL;