net: qca_spi: Introduce stat about bad signature

In order to identify significant signature issues add a new stat counter,
which increases on bad signature values that causes a sync loss.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/qualcomm/qca_debug.c b/drivers/net/ethernet/qualcomm/qca_debug.c
index 702aa217a27ad4c8021665f18c37b9db8e17e25a..d59fff2fbcc63b9ce466cb91e956a848e0eb3dd4 100644 (file)
--- a/drivers/net/ethernet/qualcomm/qca_debug.c
+++ b/drivers/net/ethernet/qualcomm/qca_debug.c
@@ -62,6 +62,7 @@ static const char qcaspi_gstrings_stats[][ETH_GSTRING_LEN] = {
        "SPI errors",
        "Write verify errors",
        "Buffer available errors",
+       "Bad signature",
 };
 
 #ifdef CONFIG_DEBUG_FS

diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c
index 0937ceb08296a55684d48e6b9036799a198ea653..79fe3ec4e581918a2ea1a997ff627f1185f8f169 100644 (file)
--- a/drivers/net/ethernet/qualcomm/qca_spi.c
+++ b/drivers/net/ethernet/qualcomm/qca_spi.c
@@ -504,6 +504,9 @@ qcaspi_qca7k_sync(struct qcaspi *qca, int event)
                qcaspi_read_register(qca, SPI_REG_SIGNATURE, &signature);
                qcaspi_read_register(qca, SPI_REG_SIGNATURE, &signature);
                if (signature != QCASPI_GOOD_SIGNATURE) {
+                       if (qca->sync == QCASPI_SYNC_READY)
+                               qca->stats.bad_signature++;
+
                        qca->sync = QCASPI_SYNC_UNKNOWN;
                        netdev_dbg(qca->net_dev, "sync: got CPU on, but signature was invalid, restart\n");
                        return;
@@ -531,6 +534,7 @@ qcaspi_qca7k_sync(struct qcaspi *qca, int event)
 
                if (signature != QCASPI_GOOD_SIGNATURE) {
                        qca->sync = QCASPI_SYNC_UNKNOWN;
+                       qca->stats.bad_signature++;
                        netdev_dbg(qca->net_dev, "sync: bad signature, restart\n");
                        /* don't reset right away */
                        return;

diff --git a/drivers/net/ethernet/qualcomm/qca_spi.h b/drivers/net/ethernet/qualcomm/qca_spi.h
index d13a67e20d6504999d02cf9a89bf104d9c240bbb..3067356106f0b7b4c69e632dd22a6d699f3977b4 100644 (file)
--- a/drivers/net/ethernet/qualcomm/qca_spi.h
+++ b/drivers/net/ethernet/qualcomm/qca_spi.h
@@ -75,6 +75,7 @@ struct qcaspi_stats {
        u64 spi_err;
        u64 write_verify_failed;
        u64 buf_avail_err;
+       u64 bad_signature;
 };
 
 struct qcaspi {