staging: wfx: drop useless update of macaddr
authorJérôme Pouiller <jerome.pouiller@silabs.com>
Fri, 10 Apr 2020 13:32:39 +0000 (15:32 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Apr 2020 12:42:51 +0000 (14:42 +0200)
Mac address is set in wfx_add_interface() and removed in
wfx_remove_interface().

Currently, there is also an additional update of mac address in
wfx_do_unjoin(). It has no rationale. Mac address is already present
and nothing has changed it. Therefore, we can drop it.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200410133239.438347-20-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wfx/sta.c

index 53ab9648184a74231b3bdfc538d8d2d3bcd6f42e..f1df7717d5f4d72cce233a3909e8c3574d034cef 100644 (file)
@@ -415,7 +415,6 @@ static void wfx_do_unjoin(struct wfx_vif *wvif)
        wfx_tx_lock_flush(wvif->wdev);
        hif_reset(wvif, false);
        wfx_tx_policy_init(wvif);
-       hif_set_macaddr(wvif, wvif->vif->addr);
        if (wvif_count(wvif->wdev) <= 1)
                hif_set_block_ack_policy(wvif, 0xFF, 0xFF);
        wfx_free_event_queue(wvif);