serial: sh-sci: CIRC_CNT_TO_END() is enough
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 23 Aug 2022 14:18:37 +0000 (17:18 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Aug 2022 12:23:05 +0000 (14:23 +0200)
Testing also CIRC_CNT() with CIRC_CNT_TO_END() is unnecessary because
to latter alone covers all necessary cases.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20220823141839.165244-1-ilpo.jarvinen@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sh-sci.c

index 9ad3663b5152c40c1ad6e7137484bbb971bc20cb..cd41fe069b897d689150ae71a5c0b3c57c563497 100644 (file)
@@ -1408,9 +1408,7 @@ static void sci_dma_tx_work_fn(struct work_struct *work)
        head = xmit->head;
        tail = xmit->tail;
        buf = s->tx_dma_addr + (tail & (UART_XMIT_SIZE - 1));
-       s->tx_dma_len = min_t(unsigned int,
-               CIRC_CNT(head, tail, UART_XMIT_SIZE),
-               CIRC_CNT_TO_END(head, tail, UART_XMIT_SIZE));
+       s->tx_dma_len = CIRC_CNT_TO_END(head, tail, UART_XMIT_SIZE);
        if (!s->tx_dma_len) {
                /* Transmit buffer has been flushed */
                spin_unlock_irq(&port->lock);