sunrpc: removed redundant procp check
authorAleksandr Aprelkov <aaprelkov@usergate.com>
Wed, 27 Mar 2024 07:10:44 +0000 (14:10 +0700)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 6 May 2024 13:07:18 +0000 (09:07 -0400)
since vs_proc pointer is dereferenced before getting it's address there's
no need to check for NULL.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 8e5b67731d08 ("SUNRPC: Add a callback to initialise server requests")
Signed-off-by: Aleksandr Aprelkov <aaprelkov@usergate.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
net/sunrpc/svc.c

index b33e429336fb7f84c5766979c8ca867a990d47bd..2b4b1276d4e867d117147884afe0d7691e1199a7 100644 (file)
@@ -1265,8 +1265,6 @@ svc_generic_init_request(struct svc_rqst *rqstp,
        if (rqstp->rq_proc >= versp->vs_nproc)
                goto err_bad_proc;
        rqstp->rq_procinfo = procp = &versp->vs_proc[rqstp->rq_proc];
-       if (!procp)
-               goto err_bad_proc;
 
        /* Initialize storage for argp and resp */
        memset(rqstp->rq_argp, 0, procp->pc_argzero);