power: reset: pwr-mlxbf: change rst_pwr_hid and low_pwr_hid from global to local...
authorTom Rix <trix@redhat.com>
Wed, 29 Jun 2022 19:20:45 +0000 (15:20 -0400)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Wed, 29 Jun 2022 19:41:59 +0000 (21:41 +0200)
sparse reports
drivers/power/reset/pwr-mlxbf.c:19:12: warning: symbol 'rst_pwr_hid' was not declared. Should it be static?
drivers/power/reset/pwr-mlxbf.c:20:12: warning: symbol 'low_pwr_hid' was not declared. Should it be static?

Both rst_pwr_hid and low_pwr_hid are only used in a single function
so they should be local variables.

Fixes: a4c0094fcf76 ("power: reset: pwr-mlxbf: add BlueField SoC power control driver")
Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Asmaa Mnebhi <asmaa@nvidia.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/reset/pwr-mlxbf.c

index 1c4904c0e1f5ca609bfacc14d09878fe31115f90..12dedf841a44016d6b7113ea99e59f7922501ae0 100644 (file)
@@ -16,9 +16,6 @@
 #include <linux/reboot.h>
 #include <linux/types.h>
 
-const char *rst_pwr_hid = "MLNXBF24";
-const char *low_pwr_hid = "MLNXBF29";
-
 struct pwr_mlxbf {
        struct work_struct send_work;
        const char *hid;
@@ -31,6 +28,8 @@ static void pwr_mlxbf_send_work(struct work_struct *work)
 
 static irqreturn_t pwr_mlxbf_irq(int irq, void *ptr)
 {
+       const char *rst_pwr_hid = "MLNXBF24";
+       const char *low_pwr_hid = "MLNXBF29";
        struct pwr_mlxbf *priv = ptr;
 
        if (!strncmp(priv->hid, rst_pwr_hid, 8))