Input: msg2638 - only read linux,keycodes array if necessary
authorVincent Knecht <vincent.knecht@mailoo.org>
Wed, 30 Nov 2022 23:15:25 +0000 (15:15 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 30 Nov 2022 23:16:25 +0000 (15:16 -0800)
The linux,keycodes property is optional.
Fix the driver not probing when it's not specified.

Fixes: c18ef50346f2 ("Input: msg2638 - add support for msg2138 key events")
Signed-off-by: Vincent Knecht <vincent.knecht@mailoo.org>
Link: https://lore.kernel.org/r/20221130210202.2069213-1-vincent.knecht@mailoo.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/msg2638.c

index 51b1c0e8a76195f9486000ef22a7e6d278b99828..4c0816b09d332ef29b49c143af54af95a8a3f8a5 100644 (file)
@@ -412,13 +412,15 @@ static int msg2638_ts_probe(struct i2c_client *client)
                msg2638->num_keycodes = ARRAY_SIZE(msg2638->keycodes);
        }
 
-       error = device_property_read_u32_array(dev, "linux,keycodes",
-                                              msg2638->keycodes,
-                                              msg2638->num_keycodes);
-       if (error) {
-               dev_err(dev, "Unable to read linux,keycodes values: %d\n",
-                       error);
-               return error;
+       if (msg2638->num_keycodes > 0) {
+               error = device_property_read_u32_array(dev, "linux,keycodes",
+                                                      msg2638->keycodes,
+                                                      msg2638->num_keycodes);
+               if (error) {
+                       dev_err(dev, "Unable to read linux,keycodes values: %d\n",
+                               error);
+                       return error;
+               }
        }
 
        error = devm_request_threaded_irq(dev, client->irq,