projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
05ca14f
)
can: xilinx_can: Check return value of set_reset_mode
author
Srinivas Neeli
<srinivas.neeli@xilinx.com>
Mon, 14 Sep 2020 08:49:57 +0000
(10:49 +0200)
committer
Marc Kleine-Budde
<mkl@pengutronix.de>
Wed, 7 Oct 2020 21:18:34 +0000
(23:18 +0200)
Check return value of set_reset_mode() for error.
Addresses-Coverity: "check_return"
Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Link:
https://lore.kernel.org/r/bac2c2b857986472a11db341b3f6f7a8905ad0dd.1600073396.git.michal.simek@xilinx.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/xilinx_can.c
patch
|
blob
|
history
diff --git
a/drivers/net/can/xilinx_can.c
b/drivers/net/can/xilinx_can.c
index d3c41e6c275d2fd2f4f52f6b22f8df609db64a04..9ea6ad73b07d873ef194fd597d8cabdbd59af175 100644
(file)
--- a/
drivers/net/can/xilinx_can.c
+++ b/
drivers/net/can/xilinx_can.c
@@
-1369,9
+1369,13
@@
static irqreturn_t xcan_interrupt(int irq, void *dev_id)
static void xcan_chip_stop(struct net_device *ndev)
{
struct xcan_priv *priv = netdev_priv(ndev);
+ int ret;
/* Disable interrupts and leave the can in configuration mode */
- set_reset_mode(ndev);
+ ret = set_reset_mode(ndev);
+ if (ret < 0)
+ netdev_dbg(ndev, "set_reset_mode() Failed\n");
+
priv->can.state = CAN_STATE_STOPPED;
}