include/block.h: remove outdated comment
authorEmanuele Giuseppe Esposito <eesposit@redhat.com>
Fri, 3 Sep 2021 11:38:00 +0000 (13:38 +0200)
committerKevin Wolf <kwolf@redhat.com>
Wed, 6 Oct 2021 08:25:55 +0000 (10:25 +0200)
There are a couple of errors in bdrv_drained_begin header comment:
- block_job_pause does not exist anymore, it has been replaced
  with job_pause in b15de82867
- job_pause is automatically invoked as a .drained_begin callback
  (child_job_drained_begin) by the child_job BdrvChildClass struct
  in blockjob.c. So no additional pause should be required.

Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Message-Id: <20210903113800.59970-1-eesposit@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
include/block/block.h

index 740038a89208bc88aa22362b5fe5a52b4b85ff0b..ab987e8a9979115240b28d07d64405bf20504721 100644 (file)
@@ -751,9 +751,7 @@ bool bdrv_drain_poll(BlockDriverState *bs, bool recursive,
  * bdrv_drained_begin:
  *
  * Begin a quiesced section for exclusive access to the BDS, by disabling
- * external request sources including NBD server and device model. Note that
- * this doesn't block timers or coroutines from submitting more requests, which
- * means block_job_pause is still necessary.
+ * external request sources including NBD server, block jobs, and device model.
  *
  * This function can be recursive.
  */