video: fbdev: ssd1307fb: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
index 1e2f71c2f8a8bc78544687fe87098642f244651e..c6d5df31111d57956fa67587320a16843a24358d 100644 (file)
--- a/drivers/video/fbdev/ssd1307fb.c
+++ b/drivers/video/fbdev/ssd1307fb.c
@@ -658,9 +658,8 @@ static int ssd1307fb_probe(struct i2c_client *client)
 
        par->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
        if (IS_ERR(par->reset)) {
-               dev_err(dev, "failed to get reset gpio: %ld\n",
-                       PTR_ERR(par->reset));
-               ret = PTR_ERR(par->reset);
+               ret = dev_err_probe(dev, PTR_ERR(par->reset),
+                                   "failed to get reset gpio\n");
                goto fb_alloc_error;
        }
 
@@ -670,7 +669,7 @@ static int ssd1307fb_probe(struct i2c_client *client)
                if (ret == -ENODEV) {
                        par->vbat_reg = NULL;
                } else {
-                       dev_err(dev, "failed to get VBAT regulator: %d\n", ret);
+                       dev_err_probe(dev, ret, "failed to get VBAT regulator\n");
                        goto fb_alloc_error;
                }
        }