media: ivsc: csi: Clean up notifier set-up
authorSakari Ailus <sakari.ailus@linux.intel.com>
Mon, 16 Oct 2023 07:27:34 +0000 (10:27 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 22 Nov 2023 09:56:34 +0000 (10:56 +0100)
Use v4l2_async_nf_add_fwnode_remote() to add an async fwnode remote
sub-device sub-device to the notifier. This avoids dealing with remote
endpoints.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Tested-by: Wentong Wu <wentong.wu@intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/pci/intel/ivsc/mei_csi.c

index 19f1a47ba52d7323ab0b11e5c20965799c187d5c..f11c7b25491dd36f011dec8c038919d2315bce25 100644 (file)
@@ -645,7 +645,6 @@ static int mei_csi_parse_firmware(struct mei_csi *csi)
        };
        struct device *dev = &csi->cldev->dev;
        struct v4l2_async_connection *asd;
-       struct fwnode_handle *fwnode;
        struct fwnode_handle *ep;
        int ret;
 
@@ -664,15 +663,12 @@ static int mei_csi_parse_firmware(struct mei_csi *csi)
 
        csi->nr_of_lanes = v4l2_ep.bus.mipi_csi2.num_data_lanes;
 
-       fwnode = fwnode_graph_get_remote_endpoint(ep);
-       fwnode_handle_put(ep);
-
        v4l2_async_subdev_nf_init(&csi->notifier, &csi->subdev);
        csi->notifier.ops = &mei_csi_notify_ops;
 
-       asd = v4l2_async_nf_add_fwnode(&csi->notifier, fwnode,
-                                      struct v4l2_async_connection);
-       fwnode_handle_put(fwnode);
+       asd = v4l2_async_nf_add_fwnode_remote(&csi->notifier, ep,
+                                             struct v4l2_async_connection);
+       fwnode_handle_put(ep);
        if (IS_ERR(asd)) {
                ret = PTR_ERR(asd);
                goto out_nf_cleanup;