pc-bios/s390-ccw: struct tpi_info must be declared as aligned(4)
authorThomas Huth <thuth@redhat.com>
Tue, 8 May 2018 10:17:52 +0000 (12:17 +0200)
committerCornelia Huck <cohuck@redhat.com>
Mon, 14 May 2018 15:10:02 +0000 (17:10 +0200)
I've run into a compilation error today with the current version of GCC 8:

In file included from s390-ccw.h:49,
                 from main.c:12:
cio.h:128:1: error: alignment 1 of 'struct tpi_info' is less than 4 [-Werror=packed-not-aligned]
 } __attribute__ ((packed));
 ^
cc1: all warnings being treated as errors

Since the struct tpi_info contains an element ("struct subchannel_id schid")
which is marked as aligned(4), we've got to mark the struct tpi_info as
aligned(4), too.

CC: qemu-stable@nongnu.org
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1525774672-11913-1-git-send-email-thuth@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
pc-bios/s390-ccw/cio.h

index 55eaeee4b6a0625a6f3f4a4bdc9bc03f4a7c863a..1a0795f6455f614246e56bc6a13adb2b64002713 100644 (file)
@@ -125,7 +125,7 @@ struct tpi_info {
     __u32 reserved3  : 12;
     __u32 int_type   : 3;
     __u32 reserved4  : 12;
-} __attribute__ ((packed));
+} __attribute__ ((packed, aligned(4)));
 
 /* channel command word (type 1) */
 struct ccw1 {