staging: r8188eu: Use skb_put_data() instead of skb_put/memcpy pair
authorShang XiaoJing <shangxiaojing@huawei.com>
Tue, 27 Sep 2022 02:40:50 +0000 (10:40 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Sep 2022 08:28:15 +0000 (10:28 +0200)
Use skb_put_data() instead of skb_put() and memcpy(), which is shorter
and clear. Drop the tmp variable that is not needed any more.

Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Link: https://lore.kernel.org/r/20220927024050.13556-1-shangxiaojing@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_recv.c

index 7970e6495c7e8a3c46e8ab0d399908bd3ae712f2..bb5c3b3888e0828dff2cf9846f3628c61de24c84 100644 (file)
@@ -1411,7 +1411,6 @@ static int amsdu_to_msdu(struct adapter *padapter, struct recv_frame *prframe)
        u8      nr_subframes, i;
        unsigned char *pdata;
        struct rx_pkt_attrib *pattrib;
-       unsigned char *data_ptr;
        struct sk_buff *sub_skb, *subframes[MAX_SUBFRAME_COUNT];
 
        struct recv_priv *precvpriv = &padapter->recvpriv;
@@ -1446,8 +1445,7 @@ static int amsdu_to_msdu(struct adapter *padapter, struct recv_frame *prframe)
                sub_skb = dev_alloc_skb(nSubframe_Length + 12);
                if (sub_skb) {
                        skb_reserve(sub_skb, 12);
-                       data_ptr = (u8 *)skb_put(sub_skb, nSubframe_Length);
-                       memcpy(data_ptr, pdata, nSubframe_Length);
+                       skb_put_data(sub_skb, pdata, nSubframe_Length);
                } else {
                        sub_skb = skb_clone(prframe->pkt, GFP_ATOMIC);
                        if (sub_skb) {