USB: serial: mos7840: fix error code in mos7840_write()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 26 Jan 2021 10:26:54 +0000 (13:26 +0300)
committerJohan Hovold <johan@kernel.org>
Tue, 26 Jan 2021 14:29:57 +0000 (15:29 +0100)
This should return -ENOMEM instead of 0 if the kmalloc() fails.

Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/mos7840.c

index 23f91d658cb46db99e5fd5e51065c8ffad11f9d0..30c25ef0dacd23d693e929ef5445319f11b77443 100644 (file)
@@ -883,8 +883,10 @@ static int mos7840_write(struct tty_struct *tty, struct usb_serial_port *port,
        if (urb->transfer_buffer == NULL) {
                urb->transfer_buffer = kmalloc(URB_TRANSFER_BUFFER_SIZE,
                                               GFP_ATOMIC);
-               if (!urb->transfer_buffer)
+               if (!urb->transfer_buffer) {
+                       bytes_sent = -ENOMEM;
                        goto exit;
+               }
        }
        transfer_size = min(count, URB_TRANSFER_BUFFER_SIZE);