crypto: hisilicon - fix print/comment of SEC V2

Fixed some print, coding style and comments of HiSilicon SEC V2.

Signed-off-by: Zaibo Xu <xuzaibo@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.c b/drivers/crypto/hisilicon/sec2/sec_crypto.c
index 2475aaf0d59b9a24e5dda3435e6d15c83e307cc1..9dca9587ca54f7c221ce257eca60afaedff4a00f 100644 (file)
--- a/drivers/crypto/hisilicon/sec2/sec_crypto.c
+++ b/drivers/crypto/hisilicon/sec2/sec_crypto.c
@@ -245,16 +245,16 @@ static int sec_skcipher_init(struct crypto_skcipher *tfm)
 
        sec = sec_find_device(cpu_to_node(smp_processor_id()));
        if (!sec) {
-               pr_err("find no Hisilicon SEC device!\n");
+               pr_err("Can not find proper Hisilicon SEC device!\n");
                return -ENODEV;
        }
        ctx->sec = sec;
        qm = &sec->qm;
        dev = &qm->pdev->dev;
-       ctx->hlf_q_num = sec->ctx_q_num >> 0x1;
+       ctx->hlf_q_num = sec->ctx_q_num >> 1;
 
        /* Half of queue depth is taken as fake requests limit in the queue. */
-       ctx->fake_req_limit = QM_Q_DEPTH >> 0x1;
+       ctx->fake_req_limit = QM_Q_DEPTH >> 1;
        ctx->qp_ctx = kcalloc(sec->ctx_q_num, sizeof(struct sec_qp_ctx),
                              GFP_KERNEL);
        if (!ctx->qp_ctx)
@@ -704,7 +704,7 @@ static int sec_process(struct sec_ctx *ctx, struct sec_req *req)
 
        ret = ctx->req_op->bd_send(ctx, req);
        if (ret != -EBUSY && ret != -EINPROGRESS) {
-               dev_err(SEC_CTX_DEV(ctx), "send sec request failed!\n");
+               dev_err_ratelimited(SEC_CTX_DEV(ctx), "send sec request failed!\n");
                goto err_send_req;
        }
 

diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.h b/drivers/crypto/hisilicon/sec2/sec_crypto.h
index 097dce82834055093d831e943e5b4f3a56c7a1f2..46b3a3558be69dcac1cb5b13f24cb3590708e3d7 100644 (file)
--- a/drivers/crypto/hisilicon/sec2/sec_crypto.h
+++ b/drivers/crypto/hisilicon/sec2/sec_crypto.h
@@ -48,8 +48,8 @@ enum sec_addr_type {
 struct sec_sqe_type2 {
 
        /*
-        * mac_len: 0~5 bits
-        * a_key_len: 6~10 bits
+        * mac_len: 0~4 bits
+        * a_key_len: 5~10 bits
         * a_alg: 11~16 bits
         */
        __le32 mac_key_alg;