HID: uclogic: Expose firmware name

Some vendors reuse the same product ID for different tablets, making it
difficult for userspace to figure out which table is connected.
While matching the device name has been used in the past by userspace to
workaround this limitation, some devices have shown that this is not
always a valid approach [1].

However, if userspace could access the firmware version name, it would
be possible to know which tablet is actually connected by matching it
against a list of known firmware names [2].

This patch exposes the firmware version name in the hid->uniq field.

Link: https://github.com/linuxwacom/libwacom/issues/609
Link: https://github.com/linuxwacom/libwacom/issues/610
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>

diff --git a/drivers/hid/hid-uclogic-params.c b/drivers/hid/hid-uclogic-params.c
index 9859dad36495ad09fc2472c94e444231ed2b0974..5bab006ec165bbd24c0eb3c3c02c81a9e3af75ae 100644 (file)
--- a/drivers/hid/hid-uclogic-params.c
+++ b/drivers/hid/hid-uclogic-params.c
@@ -884,6 +884,9 @@ static int uclogic_params_huion_init(struct uclogic_params *params,
                goto cleanup;
        }
 
+       /* The firmware is used in userspace as unique identifier */
+       strscpy(hdev->uniq, ver_ptr, sizeof(hdev->uniq));
+
        /* If this is a transition firmware */
        if (strcmp(ver_ptr, transition_ver) == 0) {
                hid_dbg(hdev,