thunderbolt: Keep the domain powered when USB4 port is in redrive mode

If a DiplayPort cable is directly connected to the host routers USB4
port, there is no tunnel involved but the port is in "redrive" mode
meaning that it is re-driving the DisplayPort signals from its
DisplayPort source. In this case we need to keep the domain powered on
otherwise once the domain enters D3cold the connected monitor blanks
too.

Since this happens only on Intel Barlow Ridge add a quirk that takes
runtime PM reference if we detect that the USB4 port entered redrive
mode (and release it once it exits the mode).

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

diff --git a/drivers/thunderbolt/quirks.c b/drivers/thunderbolt/quirks.c
index e6bfa63b40aee4675293620c5326cdb160af9a19..e81de9c30eac9acc8f9a41941cbeacb82bbebd66 100644 (file)
--- a/drivers/thunderbolt/quirks.c
+++ b/drivers/thunderbolt/quirks.c
@@ -43,6 +43,12 @@ static void quirk_usb3_maximum_bandwidth(struct tb_switch *sw)
        }
 }
 
+static void quirk_block_rpm_in_redrive(struct tb_switch *sw)
+{
+       sw->quirks |= QUIRK_KEEP_POWER_IN_DP_REDRIVE;
+       tb_sw_dbg(sw, "preventing runtime PM in DP redrive mode\n");
+}
+
 struct tb_quirk {
        u16 hw_vendor_id;
        u16 hw_device_id;
@@ -86,6 +92,14 @@ static const struct tb_quirk tb_quirks[] = {
                  quirk_usb3_maximum_bandwidth },
        { 0x8087, PCI_DEVICE_ID_INTEL_BARLOW_RIDGE_HUB_40G_BRIDGE, 0x0000, 0x0000,
                  quirk_usb3_maximum_bandwidth },
+       /*
+        * Block Runtime PM in DP redrive mode for Intel Barlow Ridge host
+        * controllers.
+        */
+       { 0x8087, PCI_DEVICE_ID_INTEL_BARLOW_RIDGE_HOST_80G_NHI, 0x0000, 0x0000,
+                 quirk_block_rpm_in_redrive },
+       { 0x8087, PCI_DEVICE_ID_INTEL_BARLOW_RIDGE_HOST_40G_NHI, 0x0000, 0x0000,
+                 quirk_block_rpm_in_redrive },
        /*
         * CLx is not supported on AMD USB4 Yellow Carp and Pink Sardine platforms.
         */

diff --git a/drivers/thunderbolt/tb.c b/drivers/thunderbolt/tb.c
index 306c62c35a05870007a13567de8e788cff621ec1..c5ce7a694b27df774aeb0e9d6bf8fd7c1cd6a82e 100644 (file)
--- a/drivers/thunderbolt/tb.c
+++ b/drivers/thunderbolt/tb.c
@@ -1973,6 +1973,49 @@ static void tb_tunnel_dp(struct tb *tb)
                tb_dbg(tb, "no suitable DP IN adapter available, not tunneling\n");
 }
 
+static void tb_enter_redrive(struct tb_port *port)
+{
+       struct tb_switch *sw = port->sw;
+
+       if (!(sw->quirks & QUIRK_KEEP_POWER_IN_DP_REDRIVE))
+               return;
+
+       /*
+        * If we get hot-unplug for the DP IN port of the host router
+        * and the DP resource is not available anymore it means there
+        * is a monitor connected directly to the Type-C port and we are
+        * in "redrive" mode. For this to work we cannot enter RTD3 so
+        * we bump up the runtime PM reference count here.
+        */
+       if (!tb_port_is_dpin(port))
+               return;
+       if (tb_route(sw))
+               return;
+       if (!tb_switch_query_dp_resource(sw, port)) {
+               port->redrive = true;
+               pm_runtime_get(&sw->dev);
+               tb_port_dbg(port, "enter redrive mode, keeping powered\n");
+       }
+}
+
+static void tb_exit_redrive(struct tb_port *port)
+{
+       struct tb_switch *sw = port->sw;
+
+       if (!(sw->quirks & QUIRK_KEEP_POWER_IN_DP_REDRIVE))
+               return;
+
+       if (!tb_port_is_dpin(port))
+               return;
+       if (tb_route(sw))
+               return;
+       if (port->redrive && tb_switch_query_dp_resource(sw, port)) {
+               port->redrive = false;
+               pm_runtime_put(&sw->dev);
+               tb_port_dbg(port, "exit redrive mode\n");
+       }
+}
+
 static void tb_dp_resource_unavailable(struct tb *tb, struct tb_port *port)
 {
        struct tb_port *in, *out;
@@ -1989,7 +2032,10 @@ static void tb_dp_resource_unavailable(struct tb *tb, struct tb_port *port)
        }
 
        tunnel = tb_find_tunnel(tb, TB_TUNNEL_DP, in, out);
-       tb_deactivate_and_free_tunnel(tunnel);
+       if (tunnel)
+               tb_deactivate_and_free_tunnel(tunnel);
+       else
+               tb_enter_redrive(port);
        list_del_init(&port->list);
 
        /*
@@ -2016,6 +2062,7 @@ static void tb_dp_resource_available(struct tb *tb, struct tb_port *port)
        tb_port_dbg(port, "DP %s resource available after hotplug\n",
                    tb_port_is_dpin(port) ? "IN" : "OUT");
        list_add_tail(&port->list, &tcm->dp_resources);
+       tb_exit_redrive(port);
 
        /* Look for suitable DP IN <-> DP OUT pairs now */
        tb_tunnel_dp(tb);

diff --git a/drivers/thunderbolt/tb.h b/drivers/thunderbolt/tb.h
index 1bbbeb034e0ec7057c504340c0fa9cabfd185298..8e87d1a0005c727e24f9f1a2d6de145d2f6073d0 100644 (file)
--- a/drivers/thunderbolt/tb.h
+++ b/drivers/thunderbolt/tb.h
@@ -23,6 +23,8 @@
 #define QUIRK_FORCE_POWER_LINK_CONTROLLER              BIT(0)
 /* Disable CLx if not supported */
 #define QUIRK_NO_CLX                                   BIT(1)
+/* Need to keep power on while USB4 port is in redrive mode */
+#define QUIRK_KEEP_POWER_IN_DP_REDRIVE                 BIT(2)
 
 /**
  * struct tb_nvm - Structure holding NVM information
@@ -265,6 +267,7 @@ struct tb_bandwidth_group {
  * @group_list: The adapter is linked to the group's list of ports through this
  * @max_bw: Maximum possible bandwidth through this adapter if set to
  *         non-zero.
+ * @redrive: For DP IN, if true the adapter is in redrive mode.
  *
  * In USB4 terminology this structure represents an adapter (protocol or
  * lane adapter).
@@ -293,6 +296,7 @@ struct tb_port {
        struct tb_bandwidth_group *group;
        struct list_head group_list;
        unsigned int max_bw;
+       bool redrive;
 };
 
 /**