spi: pic32-sqi: use 'time_left' variable with wait_for_completion_timeout()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 30 Apr 2024 11:41:36 +0000 (13:41 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 30 Apr 2024 14:57:29 +0000 (23:57 +0900)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

timeout = wait_for_completion_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240430114142.28551-5-wsa+renesas@sang-engineering.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pic32-sqi.c

index 3f1e5b27776b945b8bf7b3f33cc6f0a29fe14996..0031063a7e254c574f7b5ca9bff3e0d51936cac2 100644 (file)
@@ -344,7 +344,7 @@ static int pic32_sqi_one_message(struct spi_controller *host,
        struct spi_transfer *xfer;
        struct pic32_sqi *sqi;
        int ret = 0, mode;
-       unsigned long timeout;
+       unsigned long time_left;
        u32 val;
 
        sqi = spi_controller_get_devdata(host);
@@ -410,8 +410,8 @@ static int pic32_sqi_one_message(struct spi_controller *host,
        writel(val, sqi->regs + PESQI_BD_CTRL_REG);
 
        /* wait for xfer completion */
-       timeout = wait_for_completion_timeout(&sqi->xfer_done, 5 * HZ);
-       if (timeout == 0) {
+       time_left = wait_for_completion_timeout(&sqi->xfer_done, 5 * HZ);
+       if (time_left == 0) {
                dev_err(&sqi->host->dev, "wait timedout/interrupted\n");
                ret = -ETIMEDOUT;
                msg->status = ret;