KVM: x86/mmu: fix an incorrect comment in kvm_mmu_new_pgd()
authorWei Liu <wei.liu@kernel.org>
Mon, 28 Nov 2022 21:47:09 +0000 (21:47 +0000)
committerSean Christopherson <seanjc@google.com>
Tue, 24 Jan 2023 18:05:45 +0000 (10:05 -0800)
There is no function named kvm_mmu_ensure_valid_pgd().

Fix the comment and remove the pair of braces to conform to Linux kernel
coding style.

Signed-off-by: Wei Liu <wei.liu@kernel.org>
Reviewed-by: Sean Christopherson <seanjc@google.com>
Link: https://lore.kernel.org/r/20221128214709.224710-1-wei.liu@kernel.org
Signed-off-by: Sean Christopherson <seanjc@google.com>
arch/x86/kvm/mmu/mmu.c

index aeb240b339f5488d6e79978a8df0100276d1f811..d43952fb05a60d1400877f88e43eaac23dd89c86 100644 (file)
@@ -4556,10 +4556,12 @@ void kvm_mmu_new_pgd(struct kvm_vcpu *vcpu, gpa_t new_pgd)
        struct kvm_mmu *mmu = vcpu->arch.mmu;
        union kvm_mmu_page_role new_role = mmu->root_role;
 
-       if (!fast_pgd_switch(vcpu->kvm, mmu, new_pgd, new_role)) {
-               /* kvm_mmu_ensure_valid_pgd will set up a new root.  */
+       /*
+        * Return immediately if no usable root was found, kvm_mmu_reload()
+        * will establish a valid root prior to the next VM-Enter.
+        */
+       if (!fast_pgd_switch(vcpu->kvm, mmu, new_pgd, new_role))
                return;
-       }
 
        /*
         * It's possible that the cached previous root page is obsolete because