cpufreq: sun50i: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
Acked-by: Jernej Škrabec <jernej.skrabec@gmail.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
index 4321d7bbe7695020fa8fc95d0b70aa200266e599..32a9c88f8ff6d0a27777b68363d2417afe7fa912 100644 (file)
--- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c
+++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
@@ -137,7 +137,7 @@ free_opp:
        return ret;
 }
 
-static int sun50i_cpufreq_nvmem_remove(struct platform_device *pdev)
+static void sun50i_cpufreq_nvmem_remove(struct platform_device *pdev)
 {
        int *opp_tokens = platform_get_drvdata(pdev);
        unsigned int cpu;
@@ -148,13 +148,11 @@ static int sun50i_cpufreq_nvmem_remove(struct platform_device *pdev)
                dev_pm_opp_put_prop_name(opp_tokens[cpu]);
 
        kfree(opp_tokens);
-
-       return 0;
 }
 
 static struct platform_driver sun50i_cpufreq_driver = {
        .probe = sun50i_cpufreq_nvmem_probe,
-       .remove = sun50i_cpufreq_nvmem_remove,
+       .remove_new = sun50i_cpufreq_nvmem_remove,
        .driver = {
                .name = "sun50i-cpufreq-nvmem",
        },