soc: mediatek: fix missing clk_disable_unprepare() on err in svs_resume()

Fix the missing clk_disable_unprepare() before return
from svs_resume() in the error handling case.

Signed-off-by: Peng Wu <wupeng58@huawei.com>
Reported-by: Hulk Robot <hulkci@huawei.com>
Link: https://lore.kernel.org/r/20220623070240.63382-1-wupeng58@huawei.com
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>

diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index 606a00a2e57d98e47c3c0224772c294c76cbc09d..87e05ab5155294b295133dd6c40c0dd6fac64762 100644 (file)
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -1526,16 +1526,20 @@ static int svs_resume(struct device *dev)
        ret = reset_control_deassert(svsp->rst);
        if (ret) {
                dev_err(svsp->dev, "cannot deassert reset %d\n", ret);
-               return ret;
+               goto out_of_resume;
        }
 
        ret = svs_init02(svsp);
        if (ret)
-               return ret;
+               goto out_of_resume;
 
        svs_mon_mode(svsp);
 
        return 0;
+
+out_of_resume:
+       clk_disable_unprepare(svsp->main_clk);
+       return ret;
 }
 
 static int svs_bank_resource_setup(struct svs_platform *svsp)