target/arm: Tidy condition in disas_simd_two_reg_misc
authorRichard Henderson <richard.henderson@linaro.org>
Fri, 4 May 2018 17:05:51 +0000 (18:05 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Fri, 4 May 2018 17:05:51 +0000 (18:05 +0100)
Path analysis shows that size == 3 && !is_q has been eliminated.

Fixes: Coverity CID1385853
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 20180501180455.11214-3-richard.henderson@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
target/arm/translate-a64.c

index 97950dce1acff7c3345a6b6b5e1c6c5ac4c57e54..6d49f30b4a4e3ffa7dff3dd94a44ba3133b8d649 100644 (file)
@@ -11473,7 +11473,11 @@ static void disas_simd_two_reg_misc(DisasContext *s, uint32_t insn)
         /* All 64-bit element operations can be shared with scalar 2misc */
         int pass;
 
-        for (pass = 0; pass < (is_q ? 2 : 1); pass++) {
+        /* Coverity claims (size == 3 && !is_q) has been eliminated
+         * from all paths leading to here.
+         */
+        tcg_debug_assert(is_q);
+        for (pass = 0; pass < 2; pass++) {
             TCGv_i64 tcg_op = tcg_temp_new_i64();
             TCGv_i64 tcg_res = tcg_temp_new_i64();