pinctrl: k210: call of_node_put()
authorZhangPeng <zhangpeng362@huawei.com>
Tue, 22 Nov 2022 07:58:53 +0000 (07:58 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 22 Nov 2022 08:35:27 +0000 (09:35 +0100)
Since for_each_available_child_of_node() will increase the refcount of
node, we need to call of_node_put() manually when breaking out of the
iteration.

Fixes: d4c34d09ab03 ("pinctrl: Add RISC-V Canaan Kendryte K210 FPIOA driver")
Signed-off-by: ZhangPeng <zhangpeng362@huawei.com>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Link: https://lore.kernel.org/r/20221122075853.2496680-1-zhangpeng362@huawei.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-k210.c

index 288e44457fec2f1b1b98475480f702edd25c7d6d..97920fb517bc64823c76afbf18ce4a692466a6b0 100644 (file)
@@ -864,8 +864,10 @@ static int k210_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
        for_each_available_child_of_node(np_config, np) {
                ret = k210_pinctrl_dt_subnode_to_map(pctldev, np, map,
                                                     &reserved_maps, num_maps);
-               if (ret < 0)
+               if (ret < 0) {
+                       of_node_put(np);
                        goto err;
+               }
        }
        return 0;