template: add some missing test cases for First

diff --git a/tpl/template.go b/tpl/template.go
index dedb94f8e9eda5b63c791cc351d6a091de9f3e2c..c61a91dc7b76d365a62280e054d7e276d407bc52 100644 (file)
--- a/tpl/template.go
+++ b/tpl/template.go
@@ -289,6 +289,11 @@ func indirect(v reflect.Value) (rv reflect.Value, isNil bool) {
 // First is exposed to templates, to iterate over the first N items in a
 // rangeable list.
 func First(limit interface{}, seq interface{}) (interface{}, error) {
+
+       if limit == nil || seq == nil {
+               return nil, errors.New("both limit and seq must be provided")
+       }
+
        limitv, err := cast.ToIntE(limit)
 
        if err != nil {

diff --git a/tpl/template_test.go b/tpl/template_test.go
index 1197fa9bf9a2d5078e11f1fe403cff0cd835acf3..0c9a1ac91393620f0646ebaf9da4987c967898c0 100644 (file)
--- a/tpl/template_test.go
+++ b/tpl/template_test.go
@@ -231,6 +231,9 @@ func TestFirst(t *testing.T) {
                {"1", []int{100, 200, 300}, []int{100}},
                {int64(-1), []int{100, 200, 300}, false},
                {"noint", []int{100, 200, 300}, false},
+               {1, nil, false},
+               {nil, []int{100}, false},
+               {1, t, false},
        } {
                results, err := First(this.count, this.sequence)
                if b, ok := this.expect.(bool); ok && !b {