ext4: fix traditional comparison using max/min method

It would be better to replace the traditional ternary conditional
operator with max()/min()

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
Reviewed-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230529070930.37949-1-luhongfei@vivo.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
index 79b20d6ae39ec4205949ae9d1f9332e0835a5829..4d08bb2bd1847218b9c0745bbbbb3522878671a5 100644 (file)
--- a/fs/ext4/balloc.c
+++ b/fs/ext4/balloc.c
@@ -111,10 +111,8 @@ static unsigned ext4_num_overhead_clusters(struct super_block *sb,
        itbl_blk_start = ext4_inode_table(sb, gdp);
        itbl_blk_end = itbl_blk_start + sbi->s_itb_per_group - 1;
        if (itbl_blk_start <= end && itbl_blk_end >= start) {
-               itbl_blk_start = itbl_blk_start >= start ?
-                       itbl_blk_start : start;
-               itbl_blk_end = itbl_blk_end <= end ?
-                       itbl_blk_end : end;
+               itbl_blk_start = max(itbl_blk_start, start);
+               itbl_blk_end = min(itbl_blk_end, end);
 
                itbl_cluster_start = EXT4_B2C(sbi, itbl_blk_start - start);
                itbl_cluster_end = EXT4_B2C(sbi, itbl_blk_end - start);