crypto: caam/jr - fix Chacha20 + Poly1305 self test failure
authorGaurav Jain <gaurav.jain@nxp.com>
Thu, 21 Sep 2023 12:42:37 +0000 (18:12 +0530)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sun, 1 Oct 2023 08:28:15 +0000 (16:28 +0800)
key buffer is not copied in chachapoly_setkey function,
results in wrong output for encryption/decryption operation.

fix this by memcpy the key in caam_ctx key arrary

Fixes: d6bbd4eea243 ("crypto: caam/jr - add support for Chacha20 + Poly1305")
Signed-off-by: Gaurav Jain <gaurav.jain@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/caam/caamalg.c

index eba2d750c3b074b4de245c202c60aa12219fc052..066f08a3a040d875aab98bc9f2603fbb2381a3f6 100644 (file)
@@ -575,7 +575,8 @@ static int chachapoly_setkey(struct crypto_aead *aead, const u8 *key,
        if (keylen != CHACHA_KEY_SIZE + saltlen)
                return -EINVAL;
 
-       ctx->cdata.key_virt = key;
+       memcpy(ctx->key, key, keylen);
+       ctx->cdata.key_virt = ctx->key;
        ctx->cdata.keylen = keylen - saltlen;
 
        return chachapoly_set_sh_desc(aead);