iio: palmas: shut up warning about calibration mismatch (due to noise)
authorH. Nikolaus Schaller <hns@goldelico.com>
Tue, 8 Mar 2022 12:53:03 +0000 (13:53 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 4 Apr 2022 08:11:25 +0000 (09:11 +0100)
Although technically checking for ADC values below 0 is correct,
because they are outside of the calibration values, there is usually
noise which spuriously fills the console log with error messages if
calculated input voltage gets close to 0V.

Ignore small negative calculated values, but clamp them to 0.

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Link: https://lore.kernel.org/r/1cee45bfc3fa2ab59dcc17242fb52468035360a1.1646743982.git.hns@goldelico.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/palmas_gpadc.c

index 61e80bf3d05e462d3c44fd3cd1bc5c8f3c5fad33..fd000345ec5cff0b1201092453547e0356446876 100644 (file)
@@ -376,7 +376,8 @@ static int palmas_gpadc_get_calibrated_code(struct palmas_gpadc *adc,
                                        adc->adc_info[adc_chan].gain_error;
 
        if (val < 0) {
-               dev_err(adc->dev, "Mismatch with calibration\n");
+               if (val < -10)
+                       dev_err(adc->dev, "Mismatch with calibration var = %d\n", val);
                return 0;
        }