projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
951606a
)
ALSA: ice1712: Delete unreachable code in aureon_add_controls()
author
Dmitry Fomin
<fomindmitriyfoma@mail.ru>
Sat, 25 Feb 2023 18:43:22 +0000
(21:43 +0300)
committer
Takashi Iwai
<tiwai@suse.de>
Fri, 3 Mar 2023 13:30:46 +0000
(14:30 +0100)
If the check (id != 0x41) fails, then id == 0x41 and
the other check in 'else' branch also
fails: id & 0x0F =
0b01000001
&
0b00001111
=
0b00000001
.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Dmitry Fomin <fomindmitriyfoma@mail.ru>
Link:
https://lore.kernel.org/r/20230225184322.6286-2-fomindmitriyfoma@mail.ru
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/ice1712/aureon.c
patch
|
blob
|
history
diff --git
a/sound/pci/ice1712/aureon.c
b/sound/pci/ice1712/aureon.c
index 40a0e0095030179c7ccb642672d34990f4ab9b02..24b9782340001810f3ac051eab3129d86f98a9e2 100644
(file)
--- a/
sound/pci/ice1712/aureon.c
+++ b/
sound/pci/ice1712/aureon.c
@@
-1896,10
+1896,6
@@
static int aureon_add_controls(struct snd_ice1712 *ice)
if (id != 0x41)
dev_info(ice->card->dev,
"No CS8415 chip. Skipping CS8415 controls.\n");
- else if ((id & 0x0F) != 0x01)
- dev_info(ice->card->dev,
- "Detected unsupported CS8415 rev. (%c)\n",
- (char)((id & 0x0F) + 'A' - 1));
else {
for (i = 0; i < ARRAY_SIZE(cs8415_controls); i++) {
struct snd_kcontrol *kctl;