staging: r8188eu: simplify if-else statement

Simplify a nested if-else statement to a single if-else statement in
rtw_set_threshold(). This improves readability and allows us to
remove the local variable threshold.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20220329202141.7028-7-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
index 086d6454208254b170b1eb695632e6ea3b607608..1d52cfac199987c9e67a5675c7f18c795a45d2d3 100644 (file)
--- a/drivers/staging/r8188eu/core/rtw_mlme.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme.c
@@ -1789,20 +1789,14 @@ void rtw_update_registrypriv_dev_network(struct adapter *adapter)
 
 static void rtw_set_threshold(struct adapter *adapter)
 {
-       u8 threshold;
        struct mlme_priv *mlmepriv = &adapter->mlmepriv;
        struct ht_priv *htpriv = &mlmepriv->htpriv;
 
-       /*  TH = 1 => means that invalidate usb rx aggregation */
-       /*  TH = 0 => means that validate usb rx aggregation, use init value. */
-       if (htpriv->ht_option) {
-               if (adapter->registrypriv.wifi_spec == 1)
-                       threshold = 1;
-               else
-                       threshold = USB_RXAGG_PAGE_COUNT;
-
-               rtw_write8(adapter, REG_RXDMA_AGG_PG_TH, threshold);
+       if (htpriv->ht_option && adapter->registrypriv.wifi_spec != 1) {
+               /* validate usb rx aggregation, use init value. */
+               rtw_write8(adapter, REG_RXDMA_AGG_PG_TH, USB_RXAGG_PAGE_COUNT);
        } else {
+               /* invalidate usb rx aggregation */
                rtw_write8(adapter, REG_RXDMA_AGG_PG_TH, 1);
        }
 }